[CI] Add Danger to CI - Githubissues

plangrid / ReactiveLists

React-like API for UITableView & UICollectionView

https://plangrid.github.io/ReactiveLists

MIT License

251 stars 15 forks source link

[CI] Add Danger to CI #174

Closed anayini closed 2 years ago

anayini commented 4 years ago

Adds back Danger to CI

Changes in this pull request

Issue fixed: #

Checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[x] I have reviewed the contributing guide

anayini commented 4 years ago

In progress as Danger is reporting that this isn't a GitHub Actions PR and isn't running.

anayini commented 4 years ago

@ronaldsmartin seems to work although the danger action only runs on pull_request events. I've updated to run our check ons push and pull_request. On push events the danger action is a noop

jessesquires commented 4 years ago

Danger should be commenting on here right? Maybe make a change that would trigger it to make sure.

anayini commented 4 years ago

@jessesquires yeah I really wish there was just a manual trigger UI in this thing

jessesquires commented 4 years ago

you can run danger locally:

https://danger.systems/guides/troubleshooting.html#i-want-to-work-locally-on-my-dangerfile

ronaldsmartin commented 3 years ago

Unassigned myself from this!

jessesquires commented 2 years ago

closing this to clean up my github PRs.

and no one involved in this PR works at plangrid anymore. lol ✌🏼