plangrid / ReactiveLists

React-like API for UITableView & UICollectionView
https://plangrid.github.io/ReactiveLists
MIT License
251 stars 15 forks source link

Create datasource for cells to make lazy-loading possible #186

Closed benasher44 closed 4 years ago

benasher44 commented 4 years ago

Changes in this pull request

Allows non-Array data sources, so that we can lazy-load

Checklist

TODO

pg-infosec commented 4 years ago

Vulnerable Package: kramdown Affected Range: < 2.3.0 Fixed Version: 2.3.0 Related CVE: CVE-2020-14001 Severity: HIGH

More Information: Please consider upgrading kramdown to prevent deploying vulnerable code into production. For more information, visit: https://nvd.nist.gov/vuln/detail/CVE-2020-14001, or visit the FAQ

codecov-commenter commented 4 years ago

Codecov Report

Merging #186 into master will decrease coverage by 0.28%. The diff coverage is 86.03%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   80.84%   80.56%   -0.28%     
==========================================
  Files          31       33       +2     
  Lines        2082     2227     +145     
==========================================
+ Hits         1683     1794     +111     
- Misses        399      433      +34     
Impacted Files Coverage Δ
Sources/TableViewDriver.swift 80.00% <42.86%> (-5.90%) :arrow_down:
Sources/TableCellViewModelDataSource.swift 78.26% <78.26%> (ø)
Sources/Diffing.swift 81.11% <90.20%> (-12.22%) :arrow_down:
Sources/TableViewModel.swift 94.05% <93.94%> (-1.26%) :arrow_down:
Tests/TableView/TableViewLazyDiffingTest.swift 97.37% <97.37%> (ø)
Sources/CellContainerViewProtocol.swift 69.57% <100.00%> (ø)
Sources/UITableView+Extensions.swift 100.00% <100.00%> (ø)
Tests/TableView/TableViewDiffingTests.swift 98.72% <100.00%> (ø)
Tests/TableView/TableViewMocks.swift 94.00% <100.00%> (+0.25%) :arrow_up:
Tests/TableView/TableViewModelTests.swift 100.00% <100.00%> (ø)
... and 3 more