search

plangrid / flask-rebar

Flask-Rebar combines flask, marshmallow, and swagger for robust REST services.
MIT License
231 stars 38 forks source link

Become PEP561 compliant #138

Open Sytten opened 4 years ago

Sytten commented 4 years ago

This is already important for us since we started using mypy to type check our code. We have to ignore all code flask-rebar currently.

airstandley commented 4 years ago

So looking over PEP-561 and mypy's documentation , it appears that in order for flask-rebar to be PEP-561 compliant and still support Python 2.7, we would have to add stubs for all modules.

The other option I can see is waiting until we officially drop Python 2 support, and adding inline type-hints to the entire library.

Either seems a fairly large undertaking, but I know I'd prefer inline type hints.

@Sytten can I block this out on Python 2 deprecation, or would you want to see if anyone is up for undertaking adding stubs?

Sytten commented 4 years ago

I think we need to wait on python 2 and 3.4 deprecation, it will then be much easier and cleaner.

jab commented 3 years ago

Just noting that since this issue was last updated, the development branch has dropped Python 2 and 3.4 support (in #205) as of several months ago, nice.

dekim24 commented 1 year ago

I can take a stab at this one