search

plankanban / planka

The realtime kanban board for workgroups built with React and Redux.
https://planka.app
GNU Affero General Public License v3.0
7.89k stars 733 forks source link

Links to application URL dont work #512

Open bigrup opened 1 year ago

bigrup commented 1 year ago

Hello,

I'm trying to link to an external application, but the link inside Planka doesn't appear to be passing the URL to the browser.

I'm trying to open a specific obsidian note. When you use obisidian you can get an external deeplinked URL for that note, in this format

obsidian://open?vault=xxx&file=yyyy

I've tried putting this in raw, and also in the markdown format in the 'description' section of a note. [linktonote](obsidian://...)

The browser launches a new tab, but the URL is not transferred so the tab is blank.

i'm wondering if its a security concern and that its being dropped because its not using the http(s) schema...

Am I just doing this wrong or does this not work please?

coalwater commented 1 year ago

Just to add some extra context, I tried this yesterday and it seems when I hover on the link it has a javascript:void(0) link which behaves as expected above, opens an empty new tab.

I wanted to also verify that my browser actually supports those links, so I copy and pasted the link into the browser, and it did indeed switch to obsidian app and open the correct note.

meltyshev commented 1 year ago

Hi! We use the default react-markdown url transformer. Custom protocols can easily be excluded from sanitization, but this can add security issues. For example, on GitHub you cannot use protocols other than http/https in Markdown and there's clearly something behind it. We'll probably add the most common protocols to the exceptions, but we'll look into this first to see what problems there might be with it.

coalwater commented 12 months ago

I think a good in between option would be to allow a list of protocols via an environment variable, not much UI is needed to support it. Does this sound like something easy/easier to implement ?

santosh commented 11 months ago

Or how about having a option in preferences to enable all protocols? With some kind of warning when it is checked?

The default settings would still have it disabled.

meltyshev commented 11 months ago

Or how about having a option in preferences to enable all protocols? With some kind of warning when it is checked?

The default settings would still have it disabled.

That's also a good idea!