search

plankes-projects / splitastic

Splitastic is an open source self hosted chores/expenses splitting app.
GNU General Public License v3.0
9 stars 1 forks source link

get group pagination does not paginate anymore #79

Open plankes-projects opened 4 years ago

plankes-projects commented 4 years ago

GroupObjectDao::paginateGroups

Removed paginate because we now order groups by last_activity_date and not by id. This breaks old paginate implementation. Update the query such it works again.

we have a list of groups order by actvity (for user 1): id -> group name 4 -> group 4 3 -> group 3 1 -> group 1 2 -> group 2

paginateGroups(user: 1, limit: 2, lastId: null) shall return: 4 -> group 4 3 -> group 3

paginateGroups(user: 1, limit: 2, lastId: 3) shall return: 1 -> group 1 2 -> group 2

plankes-projects commented 4 years ago

Current client uses a limit of 50. This means we will most likely not hit the pagination functionality. Thus this bug does not have prio.