search

planningalerts-scrapers / scenic_rim

Scenic Rim Regional Council Development Applications
1 stars 4 forks source link

Update scraper.rb new base url #3

Closed thomas-deneux closed 8 years ago

equivalentideas commented 8 years ago

Hi @thomas-deneux :wave:

I've tested this works so I'll merge it :shipit:

What prompted you to fix this?

A bunch of people in the area will really appreciate your contribution :star: :star2: :star: :star2: :star:

thomas-deneux commented 8 years ago

Hi Luke,

I was just having a look at how all these scrapers and things hang together and picked a 'broken one' to have a look. It was pretty obvious what the issue was...

Are you working with / for planningalerts.org ? Or just a contributor to the scrapers ?

 Thomas Deneux Product Manager / Software Developer

APM PriceFinder.

P: 07 3666 2103 A: Level 7, 140 Ann Street Brisbane QLD 4000 E: thomas.deneux@fairfaxmedia.com.au

On 5 February 2016 at 10:35, Luke Bacon notifications@github.com wrote:

Hi @thomas-deneux https://github.com/thomas-deneux [image: :wave:]

I've tested this works so I'll merge it [image: :shipit:]

What prompted you to fix this?

A bunch of people in the area will really appreciate your contribution [image: :star:] [image: :star2:] [image: :star:] [image: :star2:] [image: :star:]

— Reply to this email directly or view it on GitHub https://github.com/planningalerts-scrapers/scenic_rim/pull/3#issuecomment-180102931 .

The information contained in this e-mail message and any accompanying files is or may be confidential. If you are not the intended recipient, any use, dissemination, reliance, forwarding, printing or copying of this e-mail or any attached files is unauthorised. This e-mail is subject to copyright. No part of it should be reproduced, adapted or communicated without the written consent of the copyright owner. If you have received this e-mail in error please advise the sender immediately by return e-mail or telephone and delete all copies. Fairfax Media does not guarantee the accuracy or completeness of any information contained in this e-mail or attached files. Internet communications are not secure, therefore Fairfax Media does not accept legal responsibility for the contents of this message or attached files.

equivalentideas commented 8 years ago

I was just having a look at how all these scrapers and things hang together and picked a 'broken one' to have a look.

Nice one :+1: there's around 40000 people living up in that area who can now find out about local planning and comment. Pretty awesome :)

Are you working with / for planningalerts.org ?

Yep I'm one of the team at the OpenAustralia Foundation that runs PlanningAlerts. We’ve got a lot of development to work on for a tiny team, so often the scraper maintenance/repair is pick up by contributors like yourself. We built morph.io to help make contributing easy and to handle all the scraping on PlanningAlerts and our other projects.