search

planningcenter / developers

Planning Center API docs and support
https://developer.planning.center/docs/
84 stars 8 forks source link

Regression to Issue #503 (Item PATCH for selected_layout no longer works) #1157

Closed MooPaw closed 7 months ago

MooPaw commented 7 months ago

Related Applications APIv2 "WorshipStorm Projector" (Services)

Describe the bug In #503, @tannermares implemented the ability for Projector to PATCH an Item to associate selected_layout (and selected_background) for an Item. The selected_background PATCH still works as expected, but the selected_layout PATCH no longer works.

To Reproduce

  1. Create a plan Item of type "item"
  2. Send an item PATCH request to change the selected_layout for the Item, such as: Payload: { data = { attributes = { }; id = 951754161; relationships = { "selected_layout" = { data = { id = 708715428; type = Layout; }; }; }; type = Item; }; }
  3. Refresh the Item - observe that the selected_layout relationship is (still) null: "relationships": { "plan": { "data": { "type": "Plan", "id": "70624495" } }, "song": { "data": null }, "arrangement": { "data": null }, "key": { "data": null }, "selected_layout": { "data": null }, "selected_background": { "data": { "type": "Attachment", "id": "154269868" } } },

Expected behavior At the time #503 was submitted, the API worked correctly. It has since broken (don't know when - a Projector customer reported the failure to save the chosen Layout ID)

I have..

tannermares commented 7 months ago

Hey @MooPaw!! Thanks for the write up! I'll look into this as soon as I can. 😊

tannermares commented 7 months ago

Hey @MooPaw! I shipped a fix for this a little bit ago. Can you verify it's all working for you again?

MooPaw commented 7 months ago

Hi @tannermares - just checked and looks like it’s all fixed!  Thanks for taking care of this so quickly - I’ll also ask the customer who reported the issue to confirm the fix.On Feb 13, 2024, at 12:50 PM, Tanner Mares @.***> wrote: Hey @MooPaw! I shipped a fix for this a little bit ago. Can you verify it's all working for you again?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

tannermares commented 7 months ago

Awesome! If for some reason it doesn't do the trick for them let's open a new issue!