Order by Membership not working

ReubsP commented 4 months ago

Affected Product Which product does this bug affect?

People

Describe the bug

Ordering people by membership returns Status 500 "Internal Server Error"

To Reproduce

Request this: https://api.planningcenteronline.com/people/v2/people?order=membership

Expected behavior

This should return a list of people, ordered by their membership.

Screenshots

Additional Context:

Endpoint: [e.g. API endpoint I'm using] people/v2/people?order=membership (With version 2023-02-15)
Language: [e.g. Programming language I'm using] Node JS (but same response from browser too)
Authentication: [e.g. OAuth 2, Personal Access Token, Browser Session (Cookie)] OAuth 2

Additional context

I have..

[x] Reviewed the documentation found at https://developer.planning.center/docs
[x] Searched for previous issues reporting this bug
[x] Removed all private information from this issue (credentials, tokens, emails, phone numbers, etc.)
[x] Reviewed my issue for completeness

seven1m commented 4 months ago

We are aware of this bug, and thank you for the report!

shanebonham commented 3 months ago

Hi @ReubsP,

This issue should be fixed now. Thanks for letting us know!

ReubsP commented 3 months ago

Thanks @shanebonham. Is it possible to still include people who don't have a membership (membership: null)? I'm pretty sure it used to do that but I could be wrong...

shanebonham commented 3 months ago

Hi @ReubsP,

I'm not actually sure whether sorting by membership previously included profiles with a null value, but that does seem to be non-standard behavior for this attribute. We'll be looking into that and I'll report back here when we've got a resolution. Thanks for bringing that to our attention!

gjack commented 2 months ago

Hi @ReubsP

We're happy to let you know that the fix for this issue is now live in production.

Thank you for being so patient!

planningcenter / developers

Order by Membership not working #1183

I have..