planningcenter / pco-release-action

Github Actions for streamlining the release process for apps that use Github releases
0 stars 0 forks source link

feat: Add Deploy Action #1

Closed kylemellander closed 2 months ago

kylemellander commented 2 months ago

This is a new action that helps to deploy our JavaScript libraries to its consumers within the organization.

It does the following things:

Where is this used/tested

This action as of yet, is not in use, but has been tested in https://github.com/planningcenter/test-js-auto-deploy-pkg and https://github.com/planningcenter/test-js-auto-deploy-consumer


danielma commented 2 months ago

I'm with @seven1m on this one. I know enough bash to write a couple one-liners here and there, but this is more complicated than I'm personally comfortable actually reviewing for any kind of completeness or bugs. Is it on the table to have this much logic in a language we're collectively more comfortable writing/reading/testing?

kylemellander commented 2 months ago

@danielma @seven1m thanks for the push to do it in ruby. It is a lot more code to set up the infrastructure, but I think its easier to grep.