planningcenter / pco-release-action

Github Actions for streamlining the release process for apps that use Github releases
0 stars 0 forks source link

fix: determine actual sha for cache key #23

Closed kylemellander closed 1 week ago

kylemellander commented 1 week ago

There was a bug that was happening when building multiple qa releases when main remained the same. The reason for this is that the cache key was based around the github.sha. This is fine when it is triggered by a normal sha, but comments triggering a run actually are run from the sha of main. This means that the build directory is cached for ANY qa build going into main and it will restore from that point until main is a new sha. An example of this occurred in add-ons.

To fix this, we are detecting the actual sha that we're using from the release that we built.