plantain-00 / schema-based-json-editor

A reactjs and vuejs component of schema based json editor.
MIT License
170 stars 39 forks source link

angular/core conflict #15

Open jasminecjc opened 6 years ago

jasminecjc commented 6 years ago

Version(if relevant): 1.0.0

"@angular/core": "^4.0.0"

Environment(if relevant):

Code(if relevant):

// code here

Expected:

Actual:

Unexpected value 'JSONEditorModule' imported by the module 'AppModule'. Please add a @NgModule annotation. My application uses angular 4, and I want to import this library to my application, but it doesn't work, I think it's because this library uses angular 5, is there any solutions?

plantain-00 commented 6 years ago

Can you confirm v7.11.1 works with angular@4?

jasminecjc commented 6 years ago

It seems not

plantain-00 commented 6 years ago

I found the Error: Metadata version mismatch for module *** schema-based-json-editor/dist/index.d.ts, found version 4, expected 3, I don't have any motivation to release another angular@4 comparable version.

you can:

  1. update your app to angular@5
  2. fork the code, and change every @angular/* to v4, then release to your own npm package