search

plantain-00 / type-coverage

A CLI tool to check type coverage for typescript code
MIT License
1.25k stars 44 forks source link

Doesn't support `#`-style private fields #121

Closed MaxNanasy closed 1 year ago

MaxNanasy commented 1 year ago

See here for an explanation of #-style private fields, and differences between using # and the private keyword

Version: 2.25.0

Code:

class TestClass {
  #hashPrivateField: any;
  private keywordPrivateField: any;
  protected keywordProtectedField: any;
  public keywordPublicField: any;
  implicitPublicField: any;
}

Expected:

$ npx -g type-coverage --detail
.../TestClass.ts:2:3: #hashPrivateField
.../TestClass.ts:3:11: keywordPrivateField
.../TestClass.ts:4:13: keywordProtectedField
.../TestClass.ts:5:10: keywordPublicField
.../TestClass.ts:6:3: implicitPublicField
1 / 6 16.66%
type-coverage success.

Actual:

$ npx -g type-coverage --detail
.../TestClass.ts:3:11: keywordPrivateField
.../TestClass.ts:4:13: keywordProtectedField
.../TestClass.ts:5:10: keywordPublicField
.../TestClass.ts:6:3: implicitPublicField
1 / 5 20.00%
type-coverage success.
plantain-00 commented 1 year ago

v2.25.1 should fix this.

MaxNanasy commented 1 year ago

Thank you, it works now :)