plantain-00 / type-coverage

A CLI tool to check type coverage for typescript code
MIT License
1.26k stars 44 forks source link

Only respect top level base url #69

Closed Raynos closed 4 years ago

Raynos commented 4 years ago

Fixes(if relevant):

I did some further debugging. The behavior actually has to be different depending on whether the top level configuration sets baseUrl or whether the config we are extending sets baseUrl.

The change merged onto master breaks code bases where a baseUrl is set in the extends target.

Also the previous change only worked because my baseUrl happened to be ./; the value we want is dirname, not baseUrl, it just happens to be that they are the same when baseUrl is ./.

I tried few more permutations of settings baseUrl in my jsconfig.json and my base-tsconfig.json files to make sure this change is actually correct.

Note that previously master was still broken when using baseUrl & extends together.

Checks

plantain-00 commented 4 years ago

released in v2.14.2

Raynos commented 4 years ago

Thanks for very quick turnaround. Can confirm v2.14.2 is working.