plantbreeding / BrAPI

Repository for version control of the BrAPI specifications
https://brapi.org
MIT License
57 stars 32 forks source link

A couple of field name inconsistencies. #547

Open guignonv opened 2 years ago

guignonv commented 2 years ago

Plural forms should be used instead of singular (to be consistent):

feserm commented 1 year ago

I also found some inconsistencies and will add them here instead of opening a new issue:

feserm commented 1 year ago

And also in BrAPI Core > Studies > /studies (array) seasons -> seasonDbIds

BrapiCoordinatorSelby commented 1 year ago

lol ok I spent more time researching this than I would like to admit: licence and license are both acceptable. As you pointed out license is the USA version (because we have to be different). For the rest of the English speaking world, licence is a noun (as in "this ontology has a licence") and license is a verb (as in "this ontology is licensed by @feserm)

For our purposes, I think licence is fine because we are using it as a noun, and we Americans can sound it out if we have to 😄