search

plantbreeding / BrAPI

Repository for version control of the BrAPI specifications
https://brapi.org
MIT License
54 stars 33 forks source link

Add support for advanced pedigree notation #589

Open trife opened 4 months ago

trife commented 4 months ago

Current pedigree only includes the simple pedigree string - "pedigreeString": "Jamestown/AGS 2060"

Advanced pedigree notation (standardized around the Purdy format) allows more complex pedigree structure - "Jamestown/3/FR-81-19/FL-302//FL-302/IN-71761-A-3-31-5-48"

A more comprehensive implementation could allow for more formats - "pedigreeString": [ { "string": "Jamestown/AGS 2060", "type": "simple" }, { "string": "Jamestown/3/FR-81-19/FL-302//FL-302/IN-71761-A-3-31-5-48", "type": "purdy" }]

BrapiCoordinatorSelby commented 4 months ago

All the examples have a simple pedigree string because it is shorter, but there is no reason why the "pedigreeString" field couldn't be used for Purdy notation right now. Are there use cases where you would want both/multiple versions? Is this truly an issue with the BrAPI spec or an issue with a data provider who is not sending Purdy notation? Could this be achieved with a request parameter? /pedigree?pedigreeStringNotation=purdy

trife commented 4 months ago

pedigreeString could be used for Purdy notation right now, but having it specifically marked as Purdy format would act as a catch for downstream tools that want to parse it using Purdy notation rules.