search

plantbreeding / BrAPI

Repository for version control of the BrAPI specifications
https://brapi.org
MIT License
57 stars 32 forks source link

Changed name to Species to OntologyTerm, removed DbIds not in 2.1 mod… #616

Open daveneti opened 1 month ago

daveneti commented 1 month ago

Changed name to Species to OntologyTerm, removed DbIds not in 2.1 model, matched ObservationUnitLevel etc with model.

daveneti commented 1 month ago

Hey @daveneti,

just reviewed your changes and there are only small changes needed.

It would certainly be helpful to adjust the validator so that it checks the associations. For example, you could automatically check whether a referencedAttribute is present and whether the type of the reverse association is correct. (If the validator is not already doing this)

@LzLang it should check references. I am also adding a CI so that the validator is run on commit. wait for @BrapiCoordinatorSelby permission.