plantbreeding / IPK-BrAPI-Validator

MIT License
4 stars 3 forks source link

Schema correction for germplasm-search | taxonId - typo #11

Closed netbofia closed 6 years ago

netbofia commented 6 years ago

https://github.com/plantbreeding/IPK-BrAPI-Validator/blob/b35b04c22c108d29d33b4d1016b7e0002e9af54b/src/main/resources/schemas/v1.1/definitions.json#L88

Hello I have been trying to validate my germplasm-search call but there seems to be a difference in the schema and the git hub specification:

Validator schema "TaxonId" should be changed to "taxonId"

https://github.com/plantbreeding/API/blob/master/Specification/Germplasm/GermplasmSearchGET.md

             "species": "acuminata",
              "taxonIds": [
                {
                  "sourceName":"ncbiTaxon",
                  "taxonId":"http://purl.obolibrary.org/obo/NCBITaxon_4641"
                }, {
                  "sourceName":"ciradTaxon",
---->           "taxonId":"23-E"}],
              "speciesAuthority": "",
              "subtaxa": "sp malaccensis var pahang",
              "subtaxaAuthority": "",

while on the validator schema we have:

            "species": {"type": ["string", "null"]},
            "taxonIds": {
                "type": ["array", "null"],
                "items": { 
                    "type": "object",
                    "properties": {
                        "sourceName" : {"type": ["string", "null"]},
-------->                   "TaxonId": {"type": ["string", "null"]}
                    },
                    "additionalProperties": false
                }
            },