search

plantbreeding / IPK-BrAPI-Validator

MIT License
4 stars 3 forks source link

testing germplasm calls #44

Closed GuilhemSempere closed 4 years ago

GuilhemSempere commented 4 years ago

I'm testing germplasm calls on https://gigwa-dev.southgreen.fr/gigwaV2/rest/Cassava-4-1_scaffolds/brapi/v1/ and:

POST /search/germplasm appears to work

GET /germplasm/{germplasmDbId} says "missing required resources", and subsequently, so does GET /germplasm/{germplasmDbId}/attributes

My understanding is it complains about having no germplasmDbId to pass to /germplasm/{germplasmDbId} but since /search/germplasm did return some data, I guess it should?!?

patrick-koenig commented 4 years ago

Dear Guilhem,

It seems that you have not implemented the mandatory resource GET /germplasm. This prevents the extraction of a necessary germplasmDbId from the response for beeing used in the consecutive schema tests like e.g. GET /germplasm/{germplasmDbId} or GET /germplasm/{germplasmDbId}/attributes. This is expressed by the error message "missing required resources".

The resource /search/germplasm is independent from the /germplasm/* resources.

germplasmDbIds extractable there are not used in the schema tests that check the group of /germplasm/* resources.

Please implement or provide the GET /germplasm resource to see if it then works. Without any parameters the /germplasm call should list a paginable list of all available germplasm.

Best, Patrick

GuilhemSempere commented 4 years ago

Thanks for providing this clue. It all seems right now.