plantphys / gsti

A project focused on the development of generalized spectra-trait models for the prediction of leaf photosynthetic capacity. This includes models focused on the prediction of leaf nitrogen, leaf mass per area (LMA), leaf water content (LWC), Vcmax, Jmax and dark respiration.
GNU General Public License v3.0
6 stars 1 forks source link

Chose the leaf temperature correction #22

Closed JulienLamour closed 1 year ago

JulienLamour commented 2 years ago

We could use the Kumarathunge et al. 2019 dependence. That would necessitate to store the mean air temperature during the growth season for each dataset.

serbinsh commented 1 year ago

I think for the initial version of this dataset and PLSR model this is beyond the scope. My concern is that we want a generalizable result and this approach is still not the most common approach used, and as you say adds some data complications in getting the appropriate met information for all samples

JulienLamour commented 1 year ago

For now, the default temperature functions and parameters are described here (Table 1) https://github.com/TESTgroup-BNL/LeafGasExchange/blob/master/Description%20of%20the%20model.docx . We decided to use the same temperature functions for all datasets. The fitting functions always give Vcmax25, Jmax25 and the Tleaf during gas exchange. So it is possible to recorrect the values using another temperature function or parametrization if needed.

JulienLamour commented 1 year ago

I have included a remark in the doc. We should be covered in the future since we provide Tleaf and the values of the parameters at 25°C so it will be possible to recalculate the parameters using other temperature functions and parameterizations if needed in the end.