plantphys / gsti

A project focused on the development of generalized spectra-trait models for the prediction of leaf photosynthetic capacity. This includes models focused on the prediction of Vcmax, Jmax and dark respiration as well as leaf nitrogen, leaf mass per area (LMA), leaf water content (LWC).
GNU General Public License v3.0
7 stars 1 forks source link

What happened to the raw data for each dataset? #27

Closed serbinsh closed 2 years ago

serbinsh commented 2 years ago

@JulienLamour I am trying to fix the LFS issues and the repo but there are some strange issues in some files. eg. .

library(LeafGasExchange)
library(spectratrait)
library(here)
path=here()
setwd(paste(path,'/Datasets/Albert_et_al_2018',sep=''))
spectra=read.csv('Copy of Wu et al. 2019 spectra brazil.csv')
load('2_Result_ACi_fitting.Rdata',verbose=TRUE)

in Albert et al. 2018 which seems like an error and I also dont see that data, unless its Wu et al. 2019 spectra panama in Wu et al?

Also we should not have spaces in any filenames

Can you let me know if things are missing? I am trying to get the repo back into working shape so we can share it.

serbinsh commented 2 years ago

OIh I see additional issues with LFS

https://github.com/TESTgroup-BNL/Global_Vcmax/blob/6c31b4b8e895c66389696da364ae59442eed1c62/Datasets/Albert_et_al_2018/LICOR_data/ACI_curve2_10252012-tnf-caferana-aci-hux1.csv

@JulienLamour do you have a recent local copy of the repo with all of the original files? If so can you send me the entire copy? I need to try and fix this. using that to try and rebuild the whole repo. At the moment there are a lot of files that dont seem to have been properly synced to git hub and/or the pointers weren't updated. Alternatively if you could rsync on your end and see if we can merge everything back together but at present this repo is unusable

serbinsh commented 2 years ago

I have attempted to fix this by removing the LFS support and putting back older datasets. But this may be imperfect and you should perhaps double check i fixed everything properly

JulienLamour commented 2 years ago

Everything worked I think

serbinsh commented 2 years ago

OK awesome! sorry I think the whole LFS thing ended up more trouble than it was worth. Hopefully we can get by without needing to use it from now on.. it would help only if we have some very large single files but maybe instead we break them up into chunks