plantuml-stdlib / Archimate-PlantUML

PlantUML macros and other includes for Archimate Diagrams
MIT License
211 stars 56 forks source link

Upgrade macros to new specs and add theme support #45

Closed ebbypeter closed 4 months ago

ebbypeter commented 4 months ago

This is an upgrade long overdue. Archimate have deprecated define and definelong parameters replacing it with function and procedure. This PR is to upgrade the macros to use the new recommendations. Additionally, theme and nesting support is added to the library. This should take care of the following issues #41, #42, #43

Changes:

New Features

ebbypeter commented 4 months ago

@Potherca Do you have time to review this PR?

Potherca commented 2 months ago

Great work @ebbypeter! I hope you don't mind the slow response, you caught in the middle of wrapping up a project and taking a vacation.

I reviewed the change post-merge, looks good to me. Love the themes as well!

Other than some personal-preference style things, the only feedback I have is: