Closed ebbypeter closed 4 months ago
@Potherca Do you have time to review this PR?
Great work @ebbypeter! I hope you don't mind the slow response, you caught in the middle of wrapping up a project and taking a vacation.
I reviewed the change post-merge, looks good to me. Love the themes as well!
Other than some personal-preference style things, the only feedback I have is:
!include <archimate/Archimate>
?^1@startuml
, but samples/Archimate-Relationships.wsd
and samples/Archimate-Sample01.wsd
are missing one?
This is an upgrade long overdue. Archimate have deprecated
define
anddefinelong
parameters replacing it withfunction
andprocedure
. This PR is to upgrade the macros to use the new recommendations. Additionally, theme and nesting support is added to the library. This should take care of the following issues #41, #42, #43Changes:
New Features