C4_Dynamic no longer numbers all relationships

[hansensmythe]

Until recently (mid-July?) diagrams could get relationships automatically numbered in order of use by using !include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Dynamic.puml

This was useful for diagramming auth chains, for example, where each relationship relies on a change of state from a previous relationship, e.g. 1: Get the object from Container 1 2: Send the object to Container 2 for modification 3: Send the object to Container 3 for further modification

However, the same diagrams now fail to number some relationships - it appears that 'Rel_L', 'Rel_R', 'Rel_U', and 'Rel_D' relationships get numbered, but plain 'Rel' relationships do not.

[kirchsth]

Hi @hansensmythe, thank you for the finding, I will check it. BR Helmut

[Potherca]

Using this diagram:

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Dynamic.puml

Boundary(a, 'Direction ""Rel""'){
    Rel_Down( Rel_Down,  X, "")
    Rel_Up(   Rel_Up,    X, "")
    Rel_Right(Rel_Right, X, "")
    Rel_Left( Rel_Left,  X, "")
}

Boundary(b, 'Direction ""Rel"" Shorthand'){
    Rel_D(Rel_D, Y, "")
    Rel_U(Rel_U, Y, "")
    Rel_R(Rel_R, Y, "")
    Rel_L(Rel_L, Y, "")
}

Boundary(c, 'Plain ""Rel"" and ""BiRel""'){
    Rel(Rel, Z, "")
    BiRel(Birel, Z, "")
}
@enduml

It can be seen that Rel and BiRel do not contain numbers, confirming @hansensmythe report.

Doing a regression check, none of the versions show a number for BiRel.

• Version 2.0 to 2.6 show numbers for all relations (except BiRel)
• Version 2.5 shows **** for BiRel
• Version 2.6 does not show numbers for Rel, Rel_Right and Rel_Up. Oddly, 2 is shown twice?

Full Regression Details

Version	Diagram
2.0	
2.1	
2.2	
2.3	
2.4	
2.5	
2.6	
2.7	

[kirchsth]

Hi @hansensmythe,

I have a bugfix in my extended branch, can you please test it with your diagrams?

!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Dynamic.puml

Thank you and best regards Helmut

[kirchsth]

@Potherca I saw you have done some tests, can you repeat it with my bugfix too? Thank you Helmut

PS,; BiRel_* was never supported

[hansensmythe]

Looks good to me! Well done, and many thanks.

Steve Hansen Smythe

Software Developer, AppDevices AppDirect 236 508 5480

On Sep 2, 2023, at 08:51, kirchsth @.***> wrote:

Hi @hansensmythe https://github.com/hansensmythe,

I have a bugfix in my extended branch, can you please test it with your diagrams?

!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Dynamic.puml http://www.plantuml.com/plantuml/uml/NPDBRzim3CVl-HHSJydG9jZMqu1XpQDOE_GHDEc6dG9QOcoXicHGTBDWs7SVvRH8lHibFlu__MbV946MjlQ3TouOtrg2IgH9doSJnjsuT5ArHPk8JGn2GSOcrfCdnwPAKatcvsTBZq4URsycz5lpbgnURXRxWBKpuoOF7jnCVzq_hZS_hzTNcvlBRvTtY-5eC9ZhG7I1U54CpVafd2nGiC149ne_a4TnCQ27rsjOcOfgpDcLHAO46GkOIfU4ksfmOHkvxk9Jg31LP05RgHJScKE9ORBvY3wT0Xf3AO6FfHv8pFXaTEGQcWzPouNIqzaIIu9fq_YNEHdZEpxZoh1h131Oc8QozSWvi-JuxAmYelSGjw04S1s4E910WU59XyAs3URmHYTxa0YcJH9huWJF3dEFOzXH0GN7NIBkmMrciGqMUJyiL6-wlEx1ZU3F060UwoO62Z8qd_9BoBIiKiVxpik6CyoCCFJ8-tJTFiXcokJAa3kSMcmg36K-D9ZIBh8zsjYJ_vY5j4zDWFm4ZjuJlv6__J5NZIJ_PQVUnzrXqUbLMuKrx5iwUx5qjKz2TPR_Er3apKEtmuDyMzHEqjlzwvXkZQlxkydLUhrSQPzsTRYTOtFqMkNIzFW9aHsE83lyEb_hkgytaISZy1ws7EiNubr5J5qSi2Ru0byxlSLihlqN56p-FVu1 Thank you and best regards Helmut

— Reply to this email directly, view it on GitHub https://github.com/plantuml-stdlib/C4-PlantUML/issues/320#issuecomment-1703871719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6ILRWQKKIDXRMGVNQAYI3XYNIZTANCNFSM6AAAAAA4H2EDW4. You are receiving this because you were mentioned.

[kirchsth]

@hansensmythe: v.2.8.0 with fix released