Closed Potherca closed 1 year ago
@Potherca - any updates on this, or were there some issues encountered?
Hello, I just realized that I missed this notification. I'm on vacations now but I will take a look in some weeks
FYI - 2 PRs opened here:
Hello @Potherca.
I think the crucial thing to define whether to upgrade to a major version (2.0) or a minor version (1.1) would be if are there any breaking changes for diagrams that already use the library.
I can think of the following scenarios:
I guess in any case that there should be some general policy in this regard for the rest of plantuml-stdlib sprites libraries
As far as I can see, there have been additions and modifications, but no deletions.
I am also not aware of any format changes that would break existing diagram.
This would mean a minor version update (i.e.e v1.1.0
).
Sounds good :). Do you want to trigger it? Or do you need me to?
I was double-checking by comparing the sprites-list.md
, using
diff v1.0..HEAD sprites-list.md
and there do seem to be some deletions/renames there:
Not 100% sure what is going on...
Uhm... Looks like the sprites-list.md
might be broken?
$ tail -n+4 sprites-list.md | wc -l
1402
$ ls sprites/*.puml | wc -l
1840
Okay. So, running the following command:
find pngs/ -name '*.png' -exec bash -c 'echo "|$(basename {} '.png')|![$(basename {} '.png')]({})|"' \; | sort > sprites-list.new
diff <(tail -n+4 sprites-list.md | sort) sprites-list.new
I got a neat list of which icons all seem to be missing form the file:
@rabelenda I've opened an MR https://github.com/plantuml-stdlib/gilbarbara-plantuml-sprites/pull/10 to resolve this.
With this MR, we can still go with an v1.1.
I just created the 1.1 release.
Thank you for taking this initiative and being so helpful and supportive @Potherca.
Regards
Merge Request has been opened in the main repo: https://github.com/plantuml/plantuml-stdlib/pull/80
As requested in https://github.com/plantuml/plantuml-stdlib/issues/69 a new version of this project should be released.
Steps to take:
SPRITESURL
in the projectREADME.md
to point to the new version#11
master
#9
logos/
in plantuml/plantuml-stdlib@rabelenda Can I tag it
v1.1.0
or would you rather see av2.0.0
?