plantuml / backlog

Contains all issues for plantuml that are not currently working-in-progress
0 stars 0 forks source link

"break" in activity fails when used in a partition, but while is outside the partition #18

Open nmz787 opened 5 years ago

nmz787 commented 5 years ago

With the partition, the break effectively act like detach but with an extra arrow pointing to nowhere. Even removing the partition, the break output line is drawn over other activity lines, and only one of the uses works, the remainder again look like detach with an arrow pointing nowehere.

with partition enabled: with partition

@startuml
skinparam padding 10
skinparam partitionBorderThickness 4

start
partition #BUSINESS "first file" {
  :start things;
    partition #PaleGoldenRod "first idea" {
    :<b>if</b> running in <b>mode A</b>, <b>then</b> all the <b>following code</b> is wrapped in a while loop "<b>while (command was NOT "quit")</b>";
    :call startup code>
    partition #Thistle "second file <b>the starting function()</b>" {
      :if this is the first time being called,
      it will send an email to the user;
    partition #MediumSpringGreen "third file <b>loop_function()</b>" {
        while (command was NOT "quit")
        :open a TCP/IP socket, unless the <b>goto_label</b> flag was previously set;
        :when data is received on the socket, call processing function>
        partition "fourth_file.c <b>processing()</b>" {
          if (command == "read")
            if (perform readA SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            :set <b>goto_label</b> variable, then return to <b>first idea</b>;
            :jump back to this line (using the C "goto" syntax);
            if (<bfirst idea</b> read SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            if (last chance)
              :perform last chance code;
              #LawnGreen:send a 0 to client;
              break
            endif
          elseif (command == "write")
            if (perform writeA SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            :set <b>resume_from_sv_operation</b> variable, then return from C to SystemVerilog;
            :jump back to this line (using the C "goto" syntax);
            if (SystemVerilog read SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            if (last chance)
              :perform last chance code;
              #LawnGreen:send a 0 to client;
              break
            endif
          elseif (command is alternate)
            :other processing;
            #LawnGreen:send result to client;
            :restart while loop;
            break
          endif
          if (other commands) then (True)
            :perform relevant processing;
          endif
        }
      endwhile
      }
    }
  }
}

@enduml

with partition disabled: without partition

@startuml
skinparam padding 10
skinparam partitionBorderThickness 4

start
partition #BUSINESS "first file" {
  :start things;
    partition #PaleGoldenRod "first idea" {
    :<b>if</b> running in <b>mode A</b>, <b>then</b> all the <b>following code</b> is wrapped in a while loop "<b>while (command was NOT "quit")</b>";
    :call startup code>
    partition #Thistle "second file <b>the starting function()</b>" {
      :if this is the first time being called,
      it will send an email to the user;
    partition #MediumSpringGreen "third file <b>loop_function()</b>" {
        while (command was NOT "quit")
        :open a TCP/IP socket, unless the <b>goto_label</b> flag was previously set;
        :when data is received on the socket, call processing function>
        'partition "fourth_file.c <b>processing()</b>" {
          if (command == "read")
            if (perform readA SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            :set <b>goto_label</b> variable, then return to <b>first idea</b>;
            :jump back to this line (using the C "goto" syntax);
            if (<bfirst idea</b> read SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            if (last chance)
              :perform last chance code;
              #LawnGreen:send a 0 to client;
              break
            endif
          elseif (command == "write")
            if (perform writeA SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            :set <b>resume_from_sv_operation</b> variable, then return from C to SystemVerilog;
            :jump back to this line (using the C "goto" syntax);
            if (SystemVerilog read SUCCEEDS) then (True)
              #LawnGreen:send result to client;
              :restart while loop;
              break
            endif
            if (last chance)
              :perform last chance code;
              #LawnGreen:send a 0 to client;
              break
            endif
          elseif (command is alternate)
            :other processing;
            #LawnGreen:send result to client;
            :restart while loop;
            break
          endif
          if (other commands) then (True)
            :perform relevant processing;
          endif
        '}
      endwhile
      }
    }
  }
}

@enduml
arnaudroques commented 1 year ago

Could you provide a shorter example that shows the issue? Thanks!