missing @enduml gives wrong error: "No @startuml found"

plantuml / backlog

Contains all issues for plantuml that are not currently working-in-progress

0 stars 0 forks source link

missing @enduml gives wrong error: "No @startuml found" #32

Open fuhrmanator opened 4 years ago

fuhrmanator commented 4 years ago

If a piped text without @enduml is sent to the .jar, it creates an error image with a misleading error "No @startuml found". We found this in the VSCode plug-in, https://github.com/qjebbs/vscode-plantuml/issues/265

Here's how to reproduce it:

$ echo -e "@startuml\nAlice -> Bob: test\n" | java -Djava.awt.headless=true -jar plantuml.jar -v -pipe > nostart.png

The error (for newbies) is confusing. Could it be fixed to report more info, e.g., "No @startuml/@enduml found"?

arnaudroques commented 1 year ago

The message is now "No diagram found". Not sure this is more useful :-)

The-Lum commented 1 month ago

Hi @fuhrmanator, and all,

FYI that is now fixed by:

plantuml/plantuml#600
plantuml/plantuml#1522

Then this issue can also be close. Regards, Th.

fuhrmanator commented 1 month ago

Sounds great! I can't see the test logs (expired) but I'm curious what the error says now.

The-Lum commented 1 month ago

Now [since Jul 29, 2021] there is no error...

Plantuml adds automaticaly the @enduml...

Enjoy, Regards, Th.

fuhrmanator commented 1 month ago

Plantuml adds automaticaly the @enduml

Someone might be disappointed to find out that their corrupted diagram (especially when it's generated code) doesn't produce an error.

The-Lum commented 1 month ago

FYI this enhancement was here since Jul 29, 2021.