Open BBX999 opened 2 years ago
Would this be hard to implement? If I wanted to work on a pull request, could someone familiar with the code base point me in the direction of which files I might need to look at / modify? Is there a resource anywhere giving a high level overview of the organization of the codebase? @The-Lum @arnaudroques
Thanks!
Hello @BBX999, and all,
Is there a resource anywhere giving a high level overview of the organization of the codebase?
No, it seems not... But you can take inspiration from the latest shapes creations:
person (added on v1.2021.4)
hexagon (added on v1.2021.1)
https://forum.plantuml.net/10418/please-provide-a-hexagon-shape?show=10418#q10418
include on https://github.com/plantuml/plantuml/commit/0dc13cccf2724ffcb4017d5dbbed63e8c706fb8f
But here are some issues 'already closed or always open':
https://forum.plantuml.net/13021/accept-hexagon-with-smetana-deployment-diagram?show=13021#q13021
https://forum.plantuml.net/13261/accept-hexagon-on-style-deployment-diagram?show=13261#q13261
https://forum.plantuml.net/14238/accept-hexagon-shape-on-nwdiag-network-diagram?show=14238#q14238
https://forum.plantuml.net/13027/link-arrow-does-not-lead-to-the-hexagon?show=13027#q13027
hollow actor (30 Oct 2020) [:warning: but that is an actor style; not a real new shape name]
If I wanted to work on a pull request, could someone familiar with the code base point me in the direction of which files I might need to look at / modify?
Then here is an attempts of list of change for new shape creation:
Adding your new shape name in:
Create your new shape with a new file USymbol<ShapeName>.java
on this directory:
Adding your shape name on param
& style
:
Adding your shape name on language:
Test...
If that can help, Regards.
That would be very useful for me as well!
Might it be possible to draw a triangle with text in it, similar to the current rectangle syntax? Or a circle for that matter (I currently achieve a circle with a very high value for the rectangle round corners using a stereotype). Thanks!