plantuml / plantuml-server

PlantUML Online Server
https://plantuml.com/
GNU General Public License v3.0
1.65k stars 472 forks source link

added docker build #187

Closed codeprefect closed 3 years ago

codeprefect commented 3 years ago

Description

Fixes the issue about docker images not generating on new releases.

Type of change

Testing Instructions

Recreating any of the existing tags should trigger a Github Action workflow that would generate new artefacts and push the necessary Docker images.

See here for artefacts from the workflow on my fork.

@arnaudroques, it is important to configure the necessary docker configurations as secrets.

DOCKERHUB_USERNAME: plantuml-server
DOCKERHUB_TOKEN: obtain from DockerHub

Checklist

[Fixes #184]

stevehipwell commented 3 years ago

@mimam419 how come you're not filtering tags to match the v* pattern? @arnaudroques could you remove and recreate the last 3 tags so we can get binaries and Docker images?

arnaudroques commented 3 years ago

@mimam419 Sorry for the delay, just created DOCKERHUB_USERNAME and DOCKERHUB_TOKEN as secret in github. Tell me if there are still some stuff to do. Thanks again!

stevehipwell commented 3 years ago

@arnaudroques is your username (DOCKERHUB_USERNAME) plantuml?

arnaudroques commented 3 years ago

@arnaudroques is your username (DOCKERHUB_USERNAME) plantuml?

Yes, it is now. Initial value was wrongly setted.

I think I have to create a new tag to trigger the GitHub action.

stevehipwell commented 3 years ago

Have you tested a docker login locally with the token?

arnaudroques commented 3 years ago

@mimam419 Many thanks for your work. I have recreated tag v1.2021.10 and something has been pushed to Docker Hub.

stevehipwell commented 3 years ago

@arnaudroques I can confirm that you have a published Docker image and I'm just about to test it.