Closed HeinrichAD closed 2 years ago
Thanks for this PR. It contains many interesting changes. However, as you said, it's huge so we cannot merge it directly. May you break it into several smaller PR so that we can review each of them ? Thanks again.
I can tackle this in the next few days/weeks. However, since this is associated with some effort, I wanted to make sure that there is interest at all.
I will leave this PR open for now and link the later ones to this.
OK. The first three pull request are available. Let's start with these changes before we update all other dependencies (artifacts, jetty and tomcat version, etc.).
I think the next step is:
I thing now everything from this PR is implemented. @arnaudroques thanks for the great cooperation.
Lastly, as I was going through the open PRs, I thought: maybe it's time to close some old PRs:
(https://docs.docker.com/buildx/working-with-buildx/#build-multi-platform-images)
Maybe the over 6 years old PRs should also be closed. I do not thing the changes are up to date anymore.
I know the PR is huge.
The changes are mainly related to external dependencies, junit tests and docker image handling.
The PR should not be merged like this! If there is an interest in these changes, I would reset the links in the readme and the GitHub workflow accordingly. Otherwise just close this PR.
Changes:
httpunit
(deprecated) to htmlunitjava.net.URL
for simple testscheckstyle
and fix errorshttp://java.sun.com/jsp/jstl/core
and its dependencies and use scriptlets Normally, this could be interpreted as a step backwards. However, since the scriptlets are only used once and thus many old dependencies could be removed, this step is worthwhile.BASE_URL
vom build argument to environment variable-slim
images to further reduce the image sizehttps
if possible