search

plantuml / plantuml-server

PlantUML Online Server
https://plantuml.com/
GNU General Public License v3.0
1.6k stars 463 forks source link

Using TCK Tested JDK builds of OpenJDK #195

Closed carldea closed 2 years ago

carldea commented 2 years ago

The AdoptOpenJDK has been discontinued since July 2021 (https://adoptopenjdk.net). Switching the distribution to Azul Zulu. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK.

Also added is a fixed (major) release version(s) such as JDK 8.0.192. This is often a good practice whenever a build/test triggers (push/pull events) to help determine if the latest (JDK 8) had failed the from the latest build vs something in your code caused (or introduced).

For example, when building with JDK 8.0.192 (fixed version) the build/tests passes (Green) and JDK 8 fails (Red) will mean that the latest JDK 8 was the cause and not your code.

Note: Other distributions such as Temurin do not support archived fixed releases prior to Sept. 2021 and many non LTS (long term support) releases if you plan to try out newer features in the language.

HeinrichAD commented 2 years ago

In the last week, the workflows have been changed a lot. In the meantime Zulu is used and it is tested against Java 11 and 17.

The problem I saw with the changes was that with each new version every release would be done twice and also the Docker images would be uploaded twice. For this reason, only the tests are currently tested against multiple versions and the releases are only created against exactly one version.

Since I was involved significantly in the changes, I would like to hear another opinion. You may even update this PR if you have further suggestions.

carldea commented 2 years ago

In the last week, the workflows have been changed a lot. In the meantime Zulu is used and it is tested against Java 11 and 17.

Glad to hear you are using Zulu for your JDK distro. Testing on consistent (up to date) TCK OpenJDK builds is key.

The problem I saw with the changes was that with each new version every release would be done twice and also the Docker images would be uploaded twice. For this reason, only the tests are currently tested against multiple versions and the releases are only created against exactly one version.

I totally agree. I think testing both versions is nice, but not upload or create two docker images.

Since I was involved significantly in the changes, I would like to hear another opinion. You may even update this PR if you have further suggestions.

You can close this PR in favor of your changes! Thank you, Carl

HeinrichAD commented 2 years ago

Thank you for your feedback!

You can close this PR in favor of your changes!

I have no rights to close an pull request. You can close the PR by yourself or wait until a maintainer reads this.