plantuml / plantuml-server

PlantUML Online Server
https://plantuml.com/
GNU General Public License v3.0
1.59k stars 463 forks source link

doc: fix some minor issues (links, name, add `<kbd>` tag, ...) #294

Closed The-Lum closed 1 year ago

The-Lum commented 1 year ago

[FYI @HeinrichAD]

HeinrichAD commented 1 year ago

LGTM.

Nice catches. Good to know that somebody is reading/using the documentation (or at least want to) :+1:.

To be honest, I expected that you added <kbd> also inside the settings. But I just saw that I didn't document that Ctrl+, or Meta+, is also opening the settings :sweat_smile:. Maybe I will add it next time or if you want you can also add it.

The-Lum commented 1 year ago

@HeinrichAD:

Maybe I will add it next time or if you want you can also add it.

That is done with #295.

Thanks for all your work of all the PlantUML WebUI, it seems now very good, and not as old school as before...

It might be interesting now to see what new other improvement would be nice... (a comparison of all the servers in place would perhaps be necessary to help in our choices.) [Maybe I can help with this]

Regards.

HeinrichAD commented 1 year ago

@The-Lum

That is done with https://github.com/plantuml/plantuml-server/pull/295.

Thanks. I already saw it and added a small question out of curiosity. Nothing that need to be changed.

Thanks for all your work of all the PlantUML WebUI, it seems now very good, and not as old school as before...

Glad to hear. Especially since I'm not a UI expert. We will see if there new issues w.r.t. the UI will be raised in the near future.

It might be interesting now to see what new other improvement would be nice...

Naturally, their are a few things that could be done. For example:

But before starting new things I would propose to re-evaluate the open issues first. I briefly check them and noticed that 50% of the open issues are already solved/answered, can't be reproduce anymore or are no longer relevant. Additionally, there are many issues which could be answered quite quickly, somebody just need to reproduce and test them or just require some more documentation. Finally, one could try to solve the reminding open issues :smile:. A few interesting issues are definitely getting lost in the crowd at the moment. The same applies to the 3 remaining pull requests as to the issues (re-evaluation).

But to be honest that is my opinion. Other people might feel differently.