plantuml / plantuml-server

PlantUML Online Server
https://plantuml.com/
GNU General Public License v3.0
1.59k stars 463 forks source link

catch 400 response for broken diagrams #300

Closed HeinrichAD closed 1 year ago

HeinrichAD commented 1 year ago

If a "broken" state of diagram code is tried to be shown, a huge error message is shown inside the log console if the diagram type is set to SVG.

Solution: catch broken diagram requests and ignore the error. The rendered error image already shows the error in detail.

HeinrichAD commented 1 year ago

Did I crashed the workflow due to the fact that I created 2 PRs at the same time :sweat_smile:.

Since the tests are successfully running inside my fork, could somebody restart the tests again. They do not really log an error. At least not according to the code changes.

Job Log

Error:

GitHub Actions has encountered an internal error when running your job.

Warning:

An image label with the label Ubuntu22 does not exist.