search

plantuml / plantuml-stdlib

Contains official Standard Library for PlantUML
556 stars 122 forks source link

Updated Classy and Classy-C4 #105

Closed james-gadrow-kr closed 6 months ago

james-gadrow-kr commented 6 months ago

Simply updated Classy and Classy-C4 to their 1.0.1 versions in order to resolve the issue reported here: https://github.com/james-gadrow-kr/classy-c4/issues/1

Note: it seems that !include doesn't only include a file one time despite what the preprocessor documentation states.

arnaudroques commented 6 months ago

Thanks for your work! However, I've seen that you have changed !include <classy-c4/externalizable-element> to !include externalizable-element.puml (for example).

It this really intentional?

james-gadrow-kr commented 6 months ago

Ah! I hadn't noticed that! I didn't realize the files were different from the ones in my base repos. Let me re-evaluate the submission for the library with this in mind.

Good spot! It seems minor so as soon as I get a break in my day I'll push up the change.

james-gadrow-kr commented 6 months ago

@arnaudroques the changes to pathing have been made now.