search

plantuml / plantuml-stdlib

Contains official Standard Library for PlantUML
557 stars 122 forks source link

AwsLib breaking change on entity casing? #47

Closed Tyrannoseanus closed 6 months ago

Tyrannoseanus commented 3 years ago

The latest change to the awslib icons (https://github.com/plantuml/plantuml-stdlib/commit/82a5108a2b773b6698f5a452d520fa0226f004dc) introduced a breaking change to a few entities- at least TapeStorage and TraditionalServer, but not in entities such as RoboMakerSimulation.

The change is that these entities are now referred to without camel case, so TraditionalServer became Traditionalserver instead.

Was this change intentional? Is there a reason some entities have been changed but others remain camel cased?

arnaudroques commented 3 years ago

@mmajis Any idea about this ?

@SeanOToole We let the community manage the stdlib. If this camel case change is an issue for your, you can submit a PR where both defines (that is Tapestorage and TapeStorage) are declared.

mmajis commented 3 years ago

This change has happened upstream. Previous version was https://github.com/awslabs/aws-icons-for-plantuml/tree/v7.0/dist/General and now we have https://github.com/awslabs/aws-icons-for-plantuml/tree/v10.0/dist/General where indeed TapeStorage has changed to Tapestorage, for example.

The-Lum commented 6 months ago

Hi all,

[This is an Issue Review] 👀 This is now answered.

Regards.