plantuml / plantuml-stdlib

Contains official Standard Library for PlantUML
556 stars 122 forks source link

AzureCommon.puml missing from Azure stdlib? #70

Closed ErikNell closed 9 months ago

ErikNell commented 1 year ago

This snippet: `@startuml !include <azure/AzureCommon>

@enduml`

will give error "Cannot include <azure/AzureCommon>"

It looks like AzureCommon.puml, AzureRaw.puml, AzureSimplified.puml and AzureC4Integration.puml are missing from the stlib. Not sure if this is intended or an oversight.

Potherca commented 1 year ago

That looks like an oversight... Those files are present in the source but it looks like they are missing in the MR https://github.com/plantuml/plantuml-stdlib/commit/db233ddaa00afa6e4fe6ac4a8de01e332b61bca4#diff-060aaf8fa63fc5f09dd0c825e526b4f29ed13996889870a6a55d86a1db63e897

I'll add a fix ASAP.

The-Lum commented 1 year ago

FYI Azure stdlib was updated last week:

Perhaps ask your question to the author/maintainer: @Potherca.

On this PR #68 , we notice the disappearance of:

Is it normal or not?

Perhaps as awslib it will be necessary to manage different version in parallel... to manage backward compatibility. (Similar to #64 and #65)

Thanks for clarification. Regards.

The-Lum commented 1 year ago

Thanks @Potherca for your prompt answer. Regards.

Potherca commented 1 year ago

Looks like I somehow missed the mentioned files and some new icons. :astonished:

I opend #71 to fix this issue. Apologies for the oversight.

@ErikNell Thank you very much for reporting this!

ErikNell commented 1 year ago

@Potherca : Thanks for the quick reaction.

The-Lum commented 9 months ago

Hi all,

[This is an Issue Review] This is now fixed.

Then you can close this issue. Regards.