fix: update graphviz version check pattern

plantuml / plantuml

Generate diagrams from textual description

https://plantuml.com

Other

9.73k stars 881 forks source link

fix: update graphviz version check pattern #1684

Closed chenrui333 closed 3 months ago

chenrui333 commented 3 months ago

Right now, the graphviz version detection failed to match with 10.x.x, thus relaxing the version check regex.

relates to #1164
also relates to https://github.com/Homebrew/homebrew-core/pull/162315

chenrui333 commented 3 months ago

@arnaudroques thanks for the merge, any chance of cutting off a new release for graphviz 10.x? Thanks! 🙏

arnaudroques commented 3 months ago

@arnaudroques thanks for the merge, any chance of cutting off a new release for graphviz 10.x? Thanks! 🙏

Yes, we will release yet a new release in the incoming days. @The-Lum I see that there are some move on standard library and themes. Do you think we can go ahead and release a new version or should we wait until the end of the week? Thanks :-)

The-Lum commented 3 months ago

Yes, the better will be this end/middle of this week...

Could you wait until middle of the week? [in order to include in stdlib: k8s, example, ...]

Regards, Th.

chenrui333 commented 3 months ago

Works for me, thanks folks!

The-Lum commented 3 months ago

Hi @arnaudroques,

⏲️ It is middle of week, then according to the new PR:

You can now package plantuml/plantuml-stdlib [with k8s and gcp], and prepare the new release of plantuml/plantuml.

Good releasing... 🚀 Regards, Th.

chenrui333 commented 3 months ago

Thanks @The-Lum!

chenrui333 commented 3 months ago

Thanks @The-Lum for the release, I can confirm plantuml works well with graphviz 10.0.1.

The-Lum commented 3 months ago

Thanks better @arnaudroques.