search

plantuml / plantuml

Generate diagrams from textual description
https://plantuml.com
Other
9.73k stars 881 forks source link

`skinparam responseMessageBelowArrow true` do not make Message Below Arrow. #1694

Closed shutaozhenzhen closed 2 months ago

shutaozhenzhen commented 2 months ago

Describe the bug skinparam responseMessageBelowArrow true do not make Message Below Arrow.

To Reproduce

  1. just use example in help book: 
    @startuml
skinparam responseMessageBelowArrow true
Bob -> Alice : hello
Alice -> Bob : ok
@enduml

Expected behavior Message Below Arrow

Screenshots image image

Desktop (please complete the following information):

also can be seen in help book example

Additional context //www.plantuml.com/plantuml/png/9Op13S8m34Nldi8Bi40FgEsT8GnyGHGdZkn4MP-W7jzxqjkZY_THb2AdsiIbi2EQrS034VB12RLvkDlaxWD4fptvTkT3qmkyyHUgHXSj_QyRMwOTzRt6Fm00

The-Lum commented 2 months ago

Hello @shutaozhenzhen,

But for that you must use "response message", as:

@startuml
skinparam responseMessageBelowArrow true
Bob -> Alice : hello
Bob <- Alice : ok
@enduml

Perhaps we must to update the doc...

Regards, Th.

The-Lum commented 2 months ago

Thanks for your report;

See complement and new behavior here:

The-Lum commented 2 months ago

Perhaps we must to update the doc...

@ PlantUML team and @arnaudroques:

[FYI: @HeinrichAD]

HeinrichAD commented 2 months ago

@The-Lum I agree with you.

I am pretty sure that per definition all code arrows from right to left <- are response arrows and all arrows from left to right -> request arrows. This is perhaps also good additional information that could be added to the documentation. Before the changes, the order of the participants was decisive. That means the direction of the rendered arrow determined if the arrow was a response arrow or not. This was quite impractical and stiff.

In my opinion, the example code inside the documentation should be changed (as you already noted) to:

@startuml
skinparam responseMessageBelowArrow true
Bob -> Alice : hello
Bob <- Alice : ok
@enduml
arnaudroques commented 2 months ago

In my opinion, the example code inside the documentation should be changed (as you already noted) to:

Yes, you are right. Sorry about that! We've just fixed the documentation.

Thanks for your help!

The-Lum commented 2 months ago

Hi all,

[This is an Issue Review] 👀 This is now fixed.

Regards.