plantuml / plantuml

Generate diagrams from textual description
https://plantuml.com
Other
9.81k stars 888 forks source link

Fixes issue plantuml#1746: (timing diagram) message labels ignore default style #1774

Closed jimnelson372 closed 3 weeks ago

jimnelson372 commented 3 weeks ago

This is the fix for issue #1746 that I mentioned in comments there.

Other than the new font settings for the TimingDiagram arrow in the plantuml.skin and rose.skin files, this change is isolated to just the TimeArrow.java file. I just had to make the textLabel get its style in a similar manner to how the text in the TimeConstraint file got its style, mostly changing the getFontConfiguration(..) method to use the same steps.

The only change after my comments in the issue discussion is that I took away the 2 space padding I had mentioned adding because I decided I didn't know all the implications of that extra padding for all rotations of the message arrow, and it wasn't part of the issue to begin with (just an esthetic preference I had). In other words, this change is now only about resolving the issue with the user configurability of the message font (style, size, color).

Let me know if you have any questions, need any changes made, etc. All the images I thought to share here are in the issue discussion.

Regards, Jim Nelson