search

plaprade / Mojocoin-Faucet

Faucet web application for Bitcoin
The Unlicense
23 stars 10 forks source link

Format balance similarly for maximum withdrawal #11

Closed jprupp closed 11 years ago

jprupp commented 11 years ago

I decided that for symmetry the balance should be formatted similarly to the total wallet amount.

plaprade commented 11 years ago

Is this consistent with what is displayed in the form "amount" input field? There could potentially be 2 different numbers displayed in page. Convince me :)

jprupp commented 11 years ago

Hey dude,

I tested it in my own laptop, and used a bitcoind with weird balance and maximum withdrawal percentages. It worked really well for me everywhere. It displays the maximum withdrawal amount nicely, consistent with balance. Not that it matters so much right now in our production faucet, since the amount is pegged at 10 testcoins these days, but it will matter if the maximum withdrawal ends up being a less round number.

When I tested the new amount display, and I tried with percentages that weren't so round, I started noticing that the discrepancy between the format of the display for balance and maximum withdrawal looked very non-aesthetic.

Cheers

plaprade commented 11 years ago

The maximum withdrawal is displayed in 2 places: Under the balance and in the "amount" input field. With this patch, there will be different code for computing these 2 maximum withdrawal values. Is this ok or should they be aligned?

jprupp commented 11 years ago

Hello,

I know what you mean now, inside the input box there's the balance displayed as well. I'm not a fan of changing the display of that amount. It's already greyed and thin. If I follow the same display rules as for the bold, big, coloured numbers on top, it's going to look really weird, and distract from the purpose of the input box, which is just typing an amount and have that background text disappear.

Cheers