search

plasma-phone-packaging / pm-flashtool

Tool for Flashing PM as LXC Container on top of CM
44 stars 27 forks source link

Problems in pm-flash.sh #12

Closed RiderExMachina closed 6 years ago

RiderExMachina commented 6 years ago

Lines 109-118 cause some issues (tl;dr - I removed "adb" in line 111 and added brackets after plasmafy in line 118):

    adb reboot recovery
    sleep 2
    adb wait-for-device
    adb reboot bootloader
    fastboot boot $CACHEDIR/$1_recovery.img

    echo "Done flashing android, now flashing rootfs and lxc"
}

function plasmafy {

This should actually be:

    adb reboot recovery
    sleep 2
    wait-for-device
    adb reboot bootloader
    fastboot boot $CACHEDIR/$1_recovery.img

    echo "Done flashing android, now flashing rootfs and lxc"
}

function plasmafy(){

However, even after these fixes, my Nexus 5X attempts to boot into the OS instead of Recovery on line 109, not entirely sure why. I'll be tinkering with it tonight, but my 5X is my one and only phone, so my testing case is severely limited to an hour or two at best.

I should also mention that even if I finish running the entire script (manually booting into recovery and then having the script take over from there, my phone boots to the BIOS screen (the Google logo) and just sits there.

RiderExMachina commented 6 years ago

Okay, so it looks like I wasn't actually in the halium-flash branch, which makes my patch from PR #13 obsolete. That said, the master branch is what's being pushed on the official Plasma Mobile site, so something does need done to make that more clear that people should use the halium-flash branch instead.

(I'm not marking this closed just yet, due to the issue stated above).

RiderExMachina commented 6 years ago

The website has been updated to use the halium-flash branch from the beginning. Because this fix is no longer an issue, (provided you follow the instructions), I'm marking this closed.