search

plasma-umass / Ninia

Python interpreter in JavaScript
Other
20 stars 8 forks source link

Implement bool() #12

Closed geremih closed 9 years ago

geremih commented 9 years ago

Implemented bool() according to Python docs, except for user-defined classes.

jvilk commented 9 years ago

I made a few comments on the code. I hope you find them useful!

geremih commented 9 years ago

Yup! Thanks a lot for your help! I'll update my PR to reflect the changes.

geremih commented 9 years ago

@jvilk I have updated my branch.

jvilk commented 9 years ago

Made some very small comments regarding style. Once those are fixed, this looks like it's ready to be merged!

geremih commented 9 years ago

@jvilk I have updated my branch.

perimosocordiae commented 9 years ago

LGTM here.