search

plasma-umass / Ninia

Python interpreter in JavaScript
Other
20 stars 8 forks source link

Fix creation of new child frames #23

Closed geremih closed 9 years ago

geremih commented 9 years ago

As https://github.com/plasma-umass/Ninia/pull/11 pointed out, there was an issue with recursion calls. The issue, I think, is not with the implementation of CALL_FUNCTION, but with the creation of child frames. When a new child frame is created off the global frame, the locals of the global frame should be passed in as the globals of the child frame.

perimosocordiae commented 9 years ago

Shouldn't the child frame's globals also include the parent frame's globals?

perimosocordiae commented 9 years ago

Answered my own question. Merging.