search

plasma-umass / Ninia

Python interpreter in JavaScript
Other
20 stars 8 forks source link

Add exception classes #35

Closed Mdrbhatti closed 9 years ago

Mdrbhatti commented 9 years ago

BaseException, Exception, NameError classes implemented.

perimosocordiae commented 9 years ago

Travis confirms loop test is fixed, hooray! The failures it reports aren't regressions, so we're good to go from a testing perspective.

Mdrbhatti commented 9 years ago

I am guilty of breaking that test inadvertently. Took me some to notice my mistake.

perimosocordiae commented 9 years ago

Aside from two minor comments, this LGTM. I'll let @jvilk do the merge, though.

jvilk commented 9 years ago

I made two minor comments. Other than those, LGTM.