Implement ArithmeticError and move exception code

plasma-umass / Ninia

Python interpreter in JavaScript

Other

20 stars 8 forks source link

Implement ArithmeticError and move exception code #36

Closed Mdrbhatti closed 9 years ago

Mdrbhatti commented 9 years ago

Move exception handling to frameobject
Implement ArithmeticError, ZeroDivisionError, AttributeError exceptions
Change trampoline frame callback to take exception argument

jvilk commented 9 years ago

I've left some comments. Let me know if you have any questions!

Mdrbhatti commented 9 years ago

I have commited the changes you mentioned.

perimosocordiae commented 9 years ago

Sorry, I made a bunch of sweeping changes that are causing a merge conflict for this PR. The merge shouldn't be too bad, but I can take responsibility for doing it once @jvilk gives the LGTM.

jvilk commented 9 years ago

Alright, I think this is ready to merge. CJ, you want to do the honors?

EDIT: actually tagging @perimosocordiae

perimosocordiae commented 9 years ago

Merged!