search

plasma-umass / Ninia

Python interpreter in JavaScript
Other
20 stars 8 forks source link

Bin implementation fix #5

Closed mfkaptan closed 9 years ago

mfkaptan commented 9 years ago

Default bin() implementation in python adds '0b' prefix when printing. Ninia should do it as well.

perimosocordiae commented 9 years ago

Looks good! Two small comments:

  1. Could you change the makefile line to $(PYTHON) $^ > $@ 2>&1? I guess &> is a bash-ism, but we still want the test output to include anything printed to stderr.
  2. There was already a test for bin() in builtinsTest.py. Either move your tests there, or move the test from there to your new test file.
perimosocordiae commented 9 years ago

Thanks! Same comments as #6 apply here: more edge case tests will be needed, but this is a good start.