search

plasma-umass / Ninia

Python interpreter in JavaScript
Other
20 stars 8 forks source link

Hex fix #6

Closed mfkaptan closed 9 years ago

mfkaptan commented 9 years ago

Add 'L' suffix if the input is type of 'Long' in hex() function.

perimosocordiae commented 9 years ago

This PR includes the changes from #5. If you feel comfortable with git, could you rebase this to only include commit a9a3683?

mfkaptan commented 9 years ago

Done! Also I removed my test since there was already another one.

perimosocordiae commented 9 years ago

Thanks, merged. We should add more tests to make sure we've covered all of the edge cases (what about negative longs?), but that can be a later PR.

mfkaptan commented 9 years ago

I think we could separate the tests in builtinsTest.py under pytests/builtins/ and put the hex.py bin.py etc. there. WDYT?

perimosocordiae commented 9 years ago

Makes sense to me. On Mar 7, 2015 12:28 PM, "Mustafa Furkan Kaptan" notifications@github.com wrote:

I think we could separate the tests in builtinsTest under pytests/builtins/ and put the hex.py bin.py etc. there. WDYT?

— Reply to this email directly or view it on GitHub https://github.com/plasma-umass/Ninia/pull/6#issuecomment-77699587.