Closed anuragagarwal561994 closed 8 years ago
Hi @anuragagarwal561994, this is looking real good! I understand you're working on -R
, so I'm going to leave this open. Additionally, it would be good to see a new test for cp in /test/test-cp.ts
. To ensure that test is run, add a line for it to test/test-all.ts
.
One additional thing, due to a limitation of our browser-node
implementation, you need to explicitly call process.exit
when done (which is why the finished
callback is passed to the log
function, otherwise the process will appear to hang even though it has successfully completed its work.
(Addresses #13)
So well there are still some of the edge cases left which I am going to cover in my next commit. Right now in case where 2 arguments are given and when the second path does not exist:
It is taking both of the paths as file only.
hi @anuragagarwal561994! The changes you made for browser-node
look great. It sounds like you have an additional commit in-progress? If you have any questions, don't hesitate to reach out on there or IRC!
this looks great, merging. We can add tests as a followup
The cases being covered here includes:
The inspiration of the implementation is taken from the core utilities of GNU.