kernel.system() API callback should provide Buffer not string

plasma-umass / browsix

Browsix is a Unix-like operating system for the browser.

Other

3.16k stars 182 forks source link

kernel.system() API callback should provide Buffer not string #3

Open bpowers opened 8 years ago

bpowers commented 8 years ago

Right now, we return a string, but we should return a Buffer. This would better match existing node.js APIs, and the output of commands isn't guaranteed to be valid unicode, so we shouldn't be doing this on behalf of callers.