Terminal: UI Improvements and Bug Fixes - Githubissues

plasma-umass / browsix

Browsix is a Unix-like operating system for the browser.

Other

3.15k stars 181 forks source link

Terminal: UI Improvements and Bug Fixes #52

Closed Hrily closed 6 years ago

Hrily commented 6 years ago

The Terminal UI has been improved for better input and output. The functionality and the overall look of terminal is just the same.

How the new UI works

Following is the high level view of new UI:

+----------------+
| $ echo hello   | -> output-container
| hello          |
+----------------+
| $ |            | -> input-container
+----------------+

Advantages

More Shell like feeling.
Output and Input are seperate.
User can't edit output (as expected, but the current ui lets user edit previous output).
Fixes the "Interesting" bug of pressing backspace multiple times #43 .
User can't delete the $
Optimized the command and output parsing in Terminal.onInput as described by:
```
// FIXME: be less horrendously inefficient.
```

Other fixes

Fixed following error:

Message:
Failed to lint: /home/hrishi/git/browsix/src/bin/mkdir.ts [121, 64]: missing whitespace.

bpowers commented 6 years ago

This sounds great, thanks @Hrily!!! Code looks good, merging. I will deploy an update to the demo on browsix in the next few days (I'm currently traveling).

Thanks again!