search

plasma-umass / browsix

Browsix is a Unix-like operating system for the browser.
Other
3.15k stars 181 forks source link

Weird prompt during make inside container for Docker based on 0.9.2 #56

Open olberger opened 6 years ago

olberger commented 6 years ago

I've rebuilt a Docker container image based on 0.9.2, which builds ok.

During "make serve" execution inside the container, there's a weird prompt "Answer" caused by a npm prompt which is hidden during the bower_components target.

I think that the following patch would help:

@@ -70,7 +70,7 @@ $(NPM_DEPS): node_modules

 bower_components: $(BOWER) bower.json
    @echo "  BOWER"
-   $(BOWER) install --silent
+   $(BOWER) install
    touch -c $@

 syscall-api: $(BUILD_DEPS)

Of course, fixing the dependencies might be an alternative.

The dialog is actually the following:

Unable to find a suitable version for test-fixture, please choose one by typing one of the numbers below:
    1) test-fixture#^1.1.1 which resolved to 1.1.2 and is required by browsix
    2) test-fixture#^3.0.0 which resolved to 3.0.0 and is required by web-component-tester#6.4.1

Prefix the choice with ! to persist it to bower.json

? Answer

When responding with first option, that seems to be working.

Hope this helps