search

plasma-umass / coz

Coz: Causal Profiling
Other
4.08k stars 159 forks source link

Use python3 for coz entry point #161

Closed sharnoff closed 4 years ago

sharnoff commented 4 years ago

Feel free to change/ignore if inappropriate - I ran into this issue on a system without python2.x, building from source. The main coz file seemed to be the culprit, but I may be wrong.

Given that the README isn't picky about a python interpreter for building from source (Python3 is merely recommended), it may be better to change this line to /usr/bin/env python, instead of python3/python2.7. I don't know what would be preferred, and it should be fairly trivial to change :)

Just figured I'd open discussion in a place that's easiest to resolve it.

Emerentius commented 4 years ago

I must warn against bare python. On several distributions python is no longer present by default. On Ubuntu 20.04, python2 and python3 both exist, but to create python, a user needs to manually create the link by installing python-is-python2 or python-is-python3.

emeryberger commented 4 years ago

Given this situation, it makes sense to leave it as python3.

emeryberger commented 4 years ago

(I've updated the documentation accordingly.)

Emerentius commented 4 years ago

The coz python file's shebang is still set to python2.7. That's what the PR originally meant to change to python3.

emeryberger commented 4 years ago

Thanks, forgot to push! (Pushed)

sharnoff commented 4 years ago

Thanks!